chore(docs): add lld mention for macOS to BUILD.md#102
Conversation
commit: |
Merging this PR will degrade performance by 11.56%
|
| Mode | Benchmark | BASE |
HEAD |
Efficiency | |
|---|---|---|---|---|---|
| ❌ | WallTime | pack large list |
63.4 ms | 72.6 ms | -12.59% |
| ❌ | WallTime | pack complex layout |
47.8 ms | 53.4 ms | -10.53% |
Tip
Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.
Comparing tbeseda:main (0bb917d) with main (9de7762)2
Footnotes
-
18 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩
-
No successful run was found on
main(5e253a7) during the generation of this report, so 9de7762 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩
|
@tbeseda thanks! It looks like the markdown needs some formatting ( We'll have to look into the benchmarks as this did not change any actual code. |
|
Here's a fix for the size checker #105 |
|
@cowboyd thanks for taking a look. I updated BUILD.md with |
2 participants
What does this PR do?
BUILD.mddoes not mention thelldrequirement for macOS. Following the instructions meansmakefails even though theclangsmoke test passes.lldis needed.I couldn't find an existing issue. If you'd rather author your own changes to BUILD.md, feel free to close this - I just wanted to make a quick fix to a small issue available.
Type of change
Checklist
These seem generic to other bombshell projects and don't apply here (
deno testdoes pass).pnpm test)pnpm format)AI-generated code disclosure
Opus 4.8 helped update the smoke test to also link and more closely match the commands used in
maketo catch other missing dependencies.